disallow manual trigger of completed tasks #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
approved these changes
Jan 23, 2025
model/task.go
Outdated
| // A task is runable when both of these condition are matched | ||
| // 1. Its max execution has not reached | ||
| // 2. Its expiration time has not reached | ||
| func (t *Task) Runable() bool { |
There was a problem hiding this comment.
I’m not sure about the naming in go, but to be consistent with the name TaskIsNotRunable, I’d call this function isRunnable(). The is will clearly indicate that this is boolean returning function.
There was a problem hiding this comment.
let me change.
name convention in go:
- anything with lower case initial is private: mean it can only be call from inside the package
- antyhing upper case is public: mean it can be call from outside(the one that import it)
so will change to IsRunable
There was a problem hiding this comment.
@chrisli30 update to IsRunable because
model/tasks.go is in package model
It was being call in package taskengine so it need to be IsRunable
This isn't just a convention in term of syntax. It's the language spec https://go.dev/ref/spec#Exported_identifiers
There was a problem hiding this comment.
Yeah, understood and sounds good!
chrisli30
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92